You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ak...@apache.org on 2019/02/06 00:09:16 UTC
[incubator-pinot] branch master updated: [TE] Fix logging bug in
migration endpoint (#3794)
This is an automated email from the ASF dual-hosted git repository.
akshayrai09 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c21ac1e [TE] Fix logging bug in migration endpoint (#3794)
c21ac1e is described below
commit c21ac1eb24104b4a7d3a972daec76b8518692a4c
Author: Akshay Rai <ak...@gmail.com>
AuthorDate: Tue Feb 5 16:09:11 2019 -0800
[TE] Fix logging bug in migration endpoint (#3794)
---
.../apache/pinot/thirdeye/detection/DetectionMigrationResource.java | 2 +-
.../pinot/thirdeye/detection/yaml/alertconfig/alert-config-1.yaml | 3 ---
.../pinot/thirdeye/detection/yaml/alertconfig/alert-config-2.yaml | 1 -
.../pinot/thirdeye/detection/yaml/alertconfig/alert-config-3.yaml | 3 ---
.../pinot/thirdeye/detection/yaml/alertconfig/alert-config-4.yaml | 3 ---
5 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
index c4504f8..80698d2 100644
--- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
+++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
@@ -418,7 +418,7 @@ public class DetectionMigrationResource {
+ " Migrated alert id " + alertConfig.getId());
}
- if (anomalyFailureCount == 0 || anomalyWarningCount == 0) {
+ if (anomalyFailureCount == 0 && anomalyWarningCount == 0) {
LOGGER.info(String.format("[MIG] Successfully migrated alert %d %s", alertConfigDTO.getId(), alertName));
} else {
throw new RuntimeException("Failures/Warnings found. anomalyFailureCount " + anomalyFailureCount + " and"
diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-1.yaml b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-1.yaml
index 6ee42f4..6a16719 100644
--- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-1.yaml
+++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-1.yaml
@@ -10,9 +10,6 @@ dimensionRecipients:
- "ios-thirdeye@thirdeye.com"
dimension: app_name
-detectionConfigIds:
- - 5773069
-
fromAddress: thirdeye-dev@linkedin.com
recipients:
diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-2.yaml b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-2.yaml
index 45ce880..ef47ca5 100644
--- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-2.yaml
+++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-2.yaml
@@ -12,7 +12,6 @@ dimensionRecipients:
- "ios-thirdeye@thirdeye.com"
dimension: app_name
-
fromAddress: thirdeye-dev@linkedin.com
recipients:
diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-3.yaml b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-3.yaml
index 63745eb..ca0c621 100644
--- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-3.yaml
+++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-3.yaml
@@ -13,9 +13,6 @@ dimensionRecipients:
- "ios-thirdeye@thirdeye.com"
dimension: app_name
-detectionConfigIds:
- - 5773069
-
fromAddress: thirdeye-dev@linkedin.com
recipients:
diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-4.yaml b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-4.yaml
index 990d68b..139fe9b 100644
--- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-4.yaml
+++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/alertconfig/alert-config-4.yaml
@@ -13,9 +13,6 @@ dimensionRecipients:
- "ios-thirdeye@thirdeye.com"
dimension: app_name
-detectionConfigIds:
- - 5773069
-
fromAddress: thirdeye-dev@linkedin.com
recipients:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org