You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ma...@apache.org on 2026/10/17 20:33:38 UTC

(activemq) 02/06: Escape special characters in destination names when building the LDAP search base

This is an automated email from the ASF dual-hosted git repository.

mattrpav pushed a commit to branch amq-ldap-hardening
in repository https://gitbox.apache.org/repos/asf/activemq.git

commit 60913c7e3bbdf588153634c7414e9cf73b93e752
Author: Matt Pavlovich <ma...@apache.org>
AuthorDate: Sat Oct 17 05:42:01 2026 -0500

    Escape special characters in destination names when building the LDAP search base
---
 .../main/java/org/apache/activemq/security/LDAPAuthorizationMap.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/activemq-broker/src/main/java/org/apache/activemq/security/LDAPAuthorizationMap.java b/activemq-broker/src/main/java/org/apache/activemq/security/LDAPAuthorizationMap.java
index 3e86f7c714..fdce83444a 100644
--- a/activemq-broker/src/main/java/org/apache/activemq/security/LDAPAuthorizationMap.java
+++ b/activemq-broker/src/main/java/org/apache/activemq/security/LDAPAuthorizationMap.java
@@ -392,7 +392,7 @@ public class LDAPAuthorizationMap implements AuthorizationMap {
             destinationBase = advisorySearchBase;
         } else {
             if ((destination.getDestinationType() & ActiveMQDestination.QUEUE_TYPE) == ActiveMQDestination.QUEUE_TYPE) {
-                destinationBase = queueSearchMatchingFormat.format(new String[]{destination.getPhysicalName()});
+                destinationBase = queueSearchMatchingFormat.format(new String[]{Rdn.escapeValue(destination.getPhysicalName())});
                 if (queueSearchSubtreeBool) {
                     constraints.setSearchScope(SearchControls.SUBTREE_SCOPE);
                 } else {
@@ -400,7 +400,7 @@ public class LDAPAuthorizationMap implements AuthorizationMap {
                 }
             }
             if ((destination.getDestinationType() & ActiveMQDestination.TOPIC_TYPE) == ActiveMQDestination.TOPIC_TYPE) {
-                destinationBase = topicSearchMatchingFormat.format(new String[]{destination.getPhysicalName()});
+                destinationBase = topicSearchMatchingFormat.format(new String[]{Rdn.escapeValue(destination.getPhysicalName())});
                 if (topicSearchSubtreeBool) {
                     constraints.setSearchScope(SearchControls.SUBTREE_SCOPE);
                 } else {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@activemq.apache.org
For additional commands, e-mail: commits-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact