You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2024/05/24 00:00:40 UTC
[I] #include "nanoarrow/nanoarrow.h" or "nanoarrow.h"? [arrow-nanoarrow]
WillAyd opened a new issue, #485:
URL: https://github.com/apache/arrow-nanoarrow/issues/485
Since we are getting closer to having nanoarrow set up in the meson wrap database, I wanted to check if it was intended to support both `#include "nanoarrow/nanoarrow.h"` and `#include "nanoarrow.h"`. Even the documentation seems to mix the two styles.
Its not a big deal, but we are explicitly adding both include directories to the meson dependency. If the long term goal was to only use one it might be easier to standardize that before we create the wrap database entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] #include "nanoarrow/nanoarrow.h" or "nanoarrow.h"? [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed issue #485: #include "nanoarrow/nanoarrow.h" or "nanoarrow.h"?
URL: https://github.com/apache/arrow-nanoarrow/issues/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] #include "nanoarrow/nanoarrow.h" or "nanoarrow.h"? [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed issue #485: #include "nanoarrow/nanoarrow.h" or "nanoarrow.h"?
URL: https://github.com/apache/arrow-nanoarrow/issues/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] #include "nanoarrow/nanoarrow.h" or "nanoarrow.h"? [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #485:
URL: https://github.com/apache/arrow-nanoarrow/issues/485#issuecomment-2128286620
It's a great point! I think that `#include "nanoarrow/nanoarrow.h"` is the slightly better (and might be the only one that works in CMake install setting). I seem to remember some trouble getting the include directories right and getting all the tests building (but it also may be that adding `src/nanoarrow` as an include directory was an early CMake line that nobody bothered to remove).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org