[GitHub] [maven] jjkester commented on a change in pull request #603: [MPH-183] BOM hierarchy in InputSource

[GitBox <gi...@apache.org>]

jjkester commented on a change in pull request #603:
URL: https://github.com/apache/maven/pull/603#discussion_r745993407



##########
File path: maven-model/src/main/mdo/maven.mdo
##########
@@ -3137,6 +3137,20 @@
             ]]>
           </description>
         </field>
+        <field>
+          <name>importedBy</name>

Review comment:
       I will look into that approach.
   
   I did consider `pluginManagement` as well, but this approach (as-is) would be easy to replicate in the similar `DefaultPluginManagementImporter`.
   
   In order to keep track of all references, I think it needs to be tracked elsewhere (and I have not found that location yet - but I will have a look).
   
   In order to support keeping the type of reference, I propose we do not reference an `InputLocation` or `InputSource` (see also the discussion [here](https://github.com/apache/maven/pull/603#discussion_r745439915)) directly, but use a container type that can be extended (for example `ReferencedInputLocation`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org