You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/22 14:37:25 UTC
[GitHub] [maven-wrapper] bmarwell opened a new pull request, #74: [BUILD] add shellcheck
bmarwell opened a new pull request, #74:
URL: https://github.com/apache/maven-wrapper/pull/74
* WHY? => Because of bashisms in this PR: https://github.com/apache/maven-wrapper/pull/65
* TODO: maybe change the output format? => https://github.com/koalaman/shellcheck/wiki/Integration#machine-parsable-output
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062272774
##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: "Shellcheck: POSIX conformity"
+
+on:
+ push:
+ pull_request:
+
+jobs:
+ shellcheck:
+ name: shellcheck
+ runs-on: ubuntu-latest
+ env:
+ SHELLCHECK_VERSION: '0.9.0'
+ SHELLCHECK_OPTS: '-e SC2009'
+ steps:
+ - uses: actions/checkout@v3
+ - name: download
+ run: |
+ curl --silent --fail --show-error --retry 2 --retry-delay 1 --connect-timeout 5 --location --url "https://github.com/koalaman/shellcheck/releases/download/v${SHELLCHECK_VERSION}/shellcheck-v${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" -o shellcheck-v${SHELLCHECK_VERSION}.tar.xz
+ tar xvf "shellcheck-v${SHELLCHECK_VERSION}.tar.xz"
+ rm -rf "shellcheck-v${SHELLCHECK_VERSION}.tar.xz"
Review Comment:
no it is not. Will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
bmarwell commented on PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#issuecomment-1363910862
Draft b/c waiting for infra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] pzygielo commented on a diff in pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062266573
##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: "Shellcheck: POSIX conformity"
+
+on:
+ push:
+ pull_request:
+
+jobs:
+ shellcheck:
+ name: shellcheck
+ runs-on: ubuntu-latest
+ env:
+ SHELLCHECK_VERSION: '0.9.0'
+ SHELLCHECK_OPTS: '-e SC2009'
+ steps:
+ - uses: actions/checkout@v3
+ - name: download
+ run: |
+ curl --silent --fail --show-error --retry 2 --retry-delay 1 --connect-timeout 5 --location --url "https://github.com/koalaman/shellcheck/releases/download/v${SHELLCHECK_VERSION}/shellcheck-v${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" -o shellcheck-v${SHELLCHECK_VERSION}.tar.xz
+ tar xvf "shellcheck-v${SHELLCHECK_VERSION}.tar.xz"
+ rm -rf "shellcheck-v${SHELLCHECK_VERSION}.tar.xz"
Review Comment:
Is that `rm` necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
bmarwell commented on PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#issuecomment-1371954691
Will add another PR which fixes the failed checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
bmarwell commented on PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#issuecomment-1366919009
@rmannibucau will now fail with:
```
./maven-wrapper-distribution/src/resources/mvnwDebug:35:68: note: Use $(...) notation instead of legacy backticks `...`. [SC2006]
./maven-wrapper-distribution/src/resources/only-mvnwDebug:24:3: note: Not following: ./mvnw was not specified as input (see shellcheck -x). [SC1091]
```
I think the first one is good, the second one needs some refining (ie exclude SC1091).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] pzygielo commented on a diff in pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062266573
##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: "Shellcheck: POSIX conformity"
+
+on:
+ push:
+ pull_request:
+
+jobs:
+ shellcheck:
+ name: shellcheck
+ runs-on: ubuntu-latest
+ env:
+ SHELLCHECK_VERSION: '0.9.0'
+ SHELLCHECK_OPTS: '-e SC2009'
+ steps:
+ - uses: actions/checkout@v3
+ - name: download
+ run: |
+ curl --silent --fail --show-error --retry 2 --retry-delay 1 --connect-timeout 5 --location --url "https://github.com/koalaman/shellcheck/releases/download/v${SHELLCHECK_VERSION}/shellcheck-v${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" -o shellcheck-v${SHELLCHECK_VERSION}.tar.xz
+ tar xvf "shellcheck-v${SHELLCHECK_VERSION}.tar.xz"
+ rm -rf "shellcheck-v${SHELLCHECK_VERSION}.tar.xz"
Review Comment:
Is that `-r` necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell merged pull request #74: [BUILD] add shellcheck
Posted by GitBox <gi...@apache.org>.
bmarwell merged PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org