[GitHub] [airflow] uranusjr commented on a diff in pull request #27428: Handle exception during serializing incompatible executor_config object.

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #27428:
URL: https://github.com/apache/airflow/pull/27428#discussion_r1064342332


##########
airflow/api_connexion/schemas/task_instance_schema.py:
##########
@@ -33,6 +33,14 @@
 from airflow.utils.state import State
 
 
+class _ExecutorConfigField(fields.String):
+    def _serialize(self, value, attr, obj, **kwargs):
+        try:
+            return super()._serialize(value, attr, obj, **kwargs)
+        except Exception:
+            return "{}"

Review Comment:
   If we don’t expect this to happen (anymore), perhaps it is better to leave the exception (which would result in a 502 reponse, persumably?)
   
   Or maybe an empty string would be viable? And we can probably document that behaviour in the API spec.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org