You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Willem Jiang (JIRA)" <ji...@apache.org> on 2011/05/24 11:00:48 UTC

[jira] [Created] (CAMEL-4008) Support to set replyTo from the message header

Support to set replyTo from the message header 
-----------------------------------------------

                 Key: CAMEL-4008
                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
             Project: Camel
          Issue Type: Improvement
          Components: camel-jms
            Reporter: Willem Jiang
            Assignee: Willem Jiang
             Fix For: 2.8.0


Here is the mail thread[1] which discusses about it.
[1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang resolved CAMEL-4008.
---------------------------------

    Resolution: Fixed

Applied patch into trunk and also update the jms wiki page.

> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040778#comment-13040778 ] 

Claus Ibsen commented on CAMEL-4008:
------------------------------------

I think we need to think about this a bit. If we are to release a Camel 2.8 in short time, then we should revert this to not introduce it in that release. That gives us more time to find a good/better solution.

> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039492#comment-13039492 ] 

Willem Jiang commented on CAMEL-4008:
-------------------------------------

Hi Claus,

This feature is just like the other message headers which give user a chance the change options those are set from the endpoint URI at the runtime. Such as CamelJmsDestination and CamelJmsDestinationName give user a chance to change the jms destination at the runtime.

As camel-jms uses the temporary queues for reply by default, the jms producer can always get the response message. So I don't astonish to find we miss this feature for a long time. 

My suggestion is to keep this feature and give user flexibility to change JMS message replyTo property at the runtime.

Willem 

> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang updated CAMEL-4008:
--------------------------------

    Attachment: CAMEL-4008.patch

Attached the patch, and just reverted it from trunk.

> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>         Attachments: CAMEL-4008.patch
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-4008:
-------------------------------

    Fix Version/s:     (was: 2.8.0)
                   Future
       Issue Type: New Feature  (was: Improvement)

> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: Future
>
>         Attachments: CAMEL-4008.patch
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039318#comment-13039318 ] 

Claus Ibsen commented on CAMEL-4008:
------------------------------------

I think this change is not so good.

When you do request/reply over Camel, eg in .to("activemq:xxx") then the reply consumer can either use
- temporary queues
- fixed reply to queue, which you must configure

Now you introduce a 3rd way using a header option. I question the use-case why this is needed.

The end user of that link got it wrong, he should do
.to("activemq:queue?replyTo=myReplyQueue")

I think we should consider reverting this patch, to keep it more KISS. 

> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reopened CAMEL-4008:
--------------------------------


> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4008) Support to set replyTo from the message header

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039730#comment-13039730 ] 

Claus Ibsen commented on CAMEL-4008:
------------------------------------

Willem there is a bigger issue when introducing this "flexibility". The reply consumer is event driven and will keep running forever (well until the route is stopped or camel is shutdown etc.). So if end user defines many different dynamic reply to queues using that new header, there will be a "leak" of resources and whatnot.

Just because its possible to add, it doesn't mean we must do it. Camel has already a lot of features and we have to be a bit careful to add more. Especially to the JMS component as its already too feature rich.



> Support to set replyTo from the message header 
> -----------------------------------------------
>
>                 Key: CAMEL-4008
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4008
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-jms
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.8.0
>
>
> Here is the mail thread[1] which discusses about it.
> [1]http://camel.465427.n5.nabble.com/set-jms-reply-to-in-message-header-td4420767.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira