You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/04 05:15:14 UTC
[GitHub] [arrow] kou opened a new pull request, #34875: MINOR: [C++][Benchmark][Acero] Fix a typo
kou opened a new pull request, #34875:
URL: https://github.com/apache/arrow/pull/34875
### Rationale for this change
It causes a build error:
```text
cpp/src/arrow/acero/hash_join_benchmark.cc:40:3: error: ‘JoinType’ does not name a type; did you mean ‘UnionType’?
40 | JoinType join_type = JoinType::INNER;
| ^~~~~~~~
| UnionType
...
```
### What changes are included in this PR?
Fix a typo.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34875: MINOR: [C++][Benchmark][Acero] Fix a typo
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34875:
URL: https://github.com/apache/arrow/pull/34875#issuecomment-1496722207
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34875: MINOR: [C++][Benchmark][Acero] Fix a typo
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34875:
URL: https://github.com/apache/arrow/pull/34875#issuecomment-1497526307
Benchmark runs are scheduled for baseline = 94492dbdd4ac7b9e62b4f3ab4931db4cb011dd7b and contender = 8824acac0064e27409d0c41178c9cf45e6ffc6fc. 8824acac0064e27409d0c41178c9cf45e6ffc6fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b9ec8e67d7f48d4a7767ad0f612dddd...4312091dbb454d1e816db6dae73c8653/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a644e452456f4d17a23de926930128c6...ba49e64751ed46a09fb08d69f71ba23f/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9e8caca5e7b4418695e1feb05cf1aec4...3d9e3d37b1a045fca37680176fed7537/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/772d86b3f23e40a594d24ef35d741b34...1219cf3a33e54ccba0c60ff85299c93f/)
Buildkite builds:
[Finished] [`8824acac` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2631)
[Failed] [`8824acac` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2663)
[Finished] [`8824acac` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2629)
[Failed] [`8824acac` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2654)
[Finished] [`94492dbd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2630)
[Failed] [`94492dbd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2662)
[Finished] [`94492dbd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2628)
[Failed] [`94492dbd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2653)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34875: MINOR: [C++][Benchmark][Acero] Fix a typo
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34875:
URL: https://github.com/apache/arrow/pull/34875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org