You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/08 21:21:50 UTC

[GitHub] [helix] NealSun96 opened a new pull request #935: Fix flaky tests in TestResourceAccessor

NealSun96 opened a new pull request #935: Fix flaky tests in TestResourceAccessor
URL: https://github.com/apache/helix/pull/935
 
 
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #933
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR fixes the flaky tests in `TestResourceAccessor`, namely `testPartitionHealth` and `testResourceHealth`. The tests have been failing because the external views created during the tests could be sometimes removed before the health check, causing health checks to fail. How to reproduce: add time delay before health check calls will always fail the test cases. 
   
   We believe that the reason behind external view removal is due to the controllers, and disabling the controllers on the test clusters has made the tests pass even with the time delay. 
   
   ### Tests
   
   - [x] The following is the result of the "mvn test" command on the appropriate module:
   
   ```
   Tests run: 112, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 121.159 sec - in TestSuite
   
   Results :
   
   Tests run: 112, Failures: 0, Errors: 0, Skipped: 0
   
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  02:04 min
   [INFO] Finished at: 2020-04-08T13:54:02-07:00
   [INFO] ------------------------------------------------------------------------
   ```
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] narendly merged pull request #935: Fix flaky tests in TestResourceAccessor

Posted by GitBox <gi...@apache.org>.
narendly merged pull request #935: Fix flaky tests in TestResourceAccessor
URL: https://github.com/apache/helix/pull/935
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] NealSun96 commented on issue #935: Fix flaky tests in TestResourceAccessor

Posted by GitBox <gi...@apache.org>.
NealSun96 commented on issue #935: Fix flaky tests in TestResourceAccessor
URL: https://github.com/apache/helix/pull/935#issuecomment-611238542
 
 
   This PR is ready to be merged, approved by @dasahcc   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org