You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/14 14:25:19 UTC

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13286: [C++] Support more pulsar command name and version in Wireshark dissector

Demogorgon314 commented on a change in pull request #13286:
URL: https://github.com/apache/pulsar/pull/13286#discussion_r768716447



##########
File path: pulsar-client-cpp/wireshark/pulsarDissector.cc
##########
@@ -78,62 +78,139 @@ static int hf_pulsar_message_permits = -1;
 
 static int ett_pulsar = -1;
 
-const static int FRAME_SIZE_LEN = 4;
+const static gint FRAME_SIZE_LEN = 4;

Review comment:
       You can see `tvb_get_ntohl(tvb, offset)`, the offset type is `gint`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org