You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/18 02:46:57 UTC

[GitHub] [skywalking] wankai123 opened a new pull request #7746: Dy conf openapi

wankai123 opened a new pull request #7746:
URL: https://github.com/apache/skywalking/pull/7746


   ### Support dynamic configurations for openAPI endpoint name grouping rule
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [X] Update the documentation to include this new feature.
   - [ X Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7746: Support dynamic configurations for openAPI endpoint name grouping rule

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7746:
URL: https://github.com/apache/skywalking/pull/7746#discussion_r711430406



##########
File path: docs/en/setup/backend/dynamic-config.md
##########
@@ -56,6 +56,10 @@ For example:
 ```
 Supported configurations are as follows:
 
+| Config Key | SubItem Key Description |  Value Description | Value Format Example |
+|:----:|:----:|:----:|:----:|
+|core.default.endpoint-name-grouping-openapi|The serviceName relevant to openAPI definition file. eg. `serviceA` If the serviceName relevant to multiple files should split with `.` eg. `serviceA.API-file1` |The openAPI definitions file contents(yaml format) for create endpoint name grouping rules.|Same as [`productAPI-v2.yaml`](endpoint-grouping-rules.md)|

Review comment:
       ```suggestion
   |core.default.endpoint-name-grouping-openapi|The serviceName relevant to openAPI definition file. eg. `serviceA` If the serviceName relevant to multiple files should split with `,` eg. `serviceA.API-file1` |The openAPI definitions file contents(yaml format) for create endpoint name grouping rules.|Same as [`productAPI-v2.yaml`](endpoint-grouping-rules.md)|
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng merged pull request #7746: Support dynamic configurations for openAPI endpoint name grouping rule

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7746:
URL: https://github.com/apache/skywalking/pull/7746


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7746: Support dynamic configurations for openAPI endpoint name grouping rule

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7746:
URL: https://github.com/apache/skywalking/pull/7746#discussion_r711432797



##########
File path: docs/en/setup/backend/dynamic-config.md
##########
@@ -56,6 +56,10 @@ For example:
 ```
 Supported configurations are as follows:
 
+| Config Key | SubItem Key Description |  Value Description | Value Format Example |
+|:----:|:----:|:----:|:----:|
+|core.default.endpoint-name-grouping-openapi|The serviceName relevant to openAPI definition file. eg. `serviceA` If the serviceName relevant to multiple files should split with `.` eg. `serviceA.API-file1` |The openAPI definitions file contents(yaml format) for create endpoint name grouping rules.|Same as [`productAPI-v2.yaml`](endpoint-grouping-rules.md)|

Review comment:
       > If the serviceName relevant to multiple files should split with `.` eg. `serviceA.API-file1`
   
   This sentence is misleading people, `.` is separating service name and file logic name. Please correct the words.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org