You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/20 10:47:19 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #18105: refactor: migrate RowCountLabel to TypeScript & added story

kgabryje commented on a change in pull request #18105:
URL: https://github.com/apache/superset/pull/18105#discussion_r788640576



##########
File path: superset-frontend/src/explore/components/RowCountLabel.tsx
##########
@@ -31,11 +31,20 @@ const propTypes = {
   loading: PropTypes.bool,
 };

Review comment:
       Now that we use typescript we don't need propTypes anymore 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org