You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2017/02/08 23:47:34 UTC
svn commit: r1782281 - in
/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp:
TFTPAckPacket.java TFTPDataPacket.java TFTPErrorPacket.java TFTPPacket.java
TFTPReadRequestPacket.java TFTPWriteRequestPacket.java
Author: sebb
Date: Wed Feb 8 23:47:34 2017
New Revision: 1782281
URL: http://svn.apache.org/viewvc?rev=1782281&view=rev
Log:
Add toString() representations for use in debugging
Modified:
commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPAckPacket.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPReadRequestPacket.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPWriteRequestPacket.java
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPAckPacket.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPAckPacket.java?rev=1782281&r1=1782280&r2=1782281&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPAckPacket.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPAckPacket.java Wed Feb 8 23:47:34 2017
@@ -158,5 +158,11 @@ public final class TFTPAckPacket extends
{
_blockNumber = blockNumber;
}
+
+ // for debugging
+ @Override
+ public String toString() {
+ return super.toString() + " ACK " + _blockNumber;
+ }
}
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java?rev=1782281&r1=1782280&r2=1782281&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPDataPacket.java Wed Feb 8 23:47:34 2017
@@ -257,4 +257,10 @@ public final class TFTPDataPacket extend
{
return _data;
}
+
+ // for debugging
+ @Override
+ public String toString() {
+ return super.toString() + " DATA " + _blockNumber + " " + _length;
+ }
}
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java?rev=1782281&r1=1782280&r2=1782281&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java Wed Feb 8 23:47:34 2017
@@ -224,4 +224,10 @@ public final class TFTPErrorPacket exten
{
return _message;
}
+
+ // for debugging
+ @Override
+ public String toString() {
+ return super.toString() + " ERR " + _error + " " + _message;
+ }
}
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java?rev=1782281&r1=1782280&r2=1782281&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPPacket.java Wed Feb 8 23:47:34 2017
@@ -249,4 +249,10 @@ public abstract class TFTPPacket
{
_address = address;
}
+
+ // for debugging
+ @Override
+ public String toString() {
+ return _address + " " + _port + " " + _type;
+ }
}
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPReadRequestPacket.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPReadRequestPacket.java?rev=1782281&r1=1782280&r2=1782281&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPReadRequestPacket.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPReadRequestPacket.java Wed Feb 8 23:47:34 2017
@@ -76,4 +76,9 @@ public final class TFTPReadRequestPacket
super(TFTPPacket.READ_REQUEST, datagram);
}
+ // for debugging
+ @Override
+ public String toString() {
+ return super.toString() + " RRQ " + getFilename() + " " + TFTP.getModeName(getMode());
+ }
}
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPWriteRequestPacket.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPWriteRequestPacket.java?rev=1782281&r1=1782280&r2=1782281&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPWriteRequestPacket.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/tftp/TFTPWriteRequestPacket.java Wed Feb 8 23:47:34 2017
@@ -75,4 +75,10 @@ public final class TFTPWriteRequestPacke
{
super(TFTPPacket.WRITE_REQUEST, datagram);
}
+
+ // for debugging
+ @Override
+ public String toString() {
+ return super.toString() + " WRQ " + getFilename() + " " + TFTP.getModeName(getMode());
+ }
}