You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/08 19:57:24 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #5690: Python: Add CLI command to list files

Fokko commented on code in PR #5690:
URL: https://github.com/apache/iceberg/pull/5690#discussion_r966368480


##########
python/pyiceberg/cli/output.py:
##########
@@ -119,25 +124,40 @@ def describe_table(self, table: Table):
         output_table.add_row("Properties", table_properties)
         Console().print(output_table)
 
-    def describe_properties(self, properties: Properties):
+    def files(self, table: Table, io: FileIO) -> None:
+        metadata = table.metadata
+
+        snapshot_tree = Tree(f"Snapshots: {'.'.join(table.identifier)}")
+        for snapshot in metadata.snapshots:

Review Comment:
   Great suggestion, just updated the PR! 👍🏻 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org