You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/07/22 19:02:28 UTC
[GitHub] [airflow] potiuk opened a new pull request, #32775: Harcode pre 2 7 defaults
potiuk opened a new pull request, #32775:
URL: https://github.com/apache/airflow/pull/32775
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
During thorough testing and review of moving configuration to provoders
I realised that there was a case that was not handled properly. In some
cases some providers and DAGs could rely on some default values being
available as default, but when we move them from core, and use older
version of provider those defaults were not available:
* they were remove as defaults in core
* the old providers did not have "config" section to contribute the
defaults
This would be a breaking change and old providers (Celery, K8s) could
fail - as it happened in some tests.
This PR implements a nice solution to that, also allowing to remove
some manual fallbacks in Celery and Kubernetes executor code.
The solution is to add a hard-coded "pre-2.7" configuration which
would only contain "provider" pre-2.7 hard-coded defaults and make
it a fallback option if the values are neither set nor defaults
contributed by the providers.
We do not have to maintain those - the defaults are "frozen"
effectively at the values available just before 2.7. The nice side
effect is that we can remove a number of fallbacks, because this
hard-coded configuration becomes the fallback automatically,
That entirely solves the case where you want to install older
providers on 2.7 where config.yml does not contain those provider
values.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32775: Add pre-Airflow-2-7 hardcoded defaults for config for older providers
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32775:
URL: https://github.com/apache/airflow/pull/32775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32775: Harcode pre 2 7 defaults
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32775:
URL: https://github.com/apache/airflow/pull/32775#issuecomment-1646651790
Based on #32765 so only last commit counts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32775: Add pre-Airflow-2-7 hardcoded defaults for config for older providers
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32775:
URL: https://github.com/apache/airflow/pull/32775#issuecomment-1646777654
Only last commit counts. The others are pre-requisite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #32775: Add pre-Airflow-2-7 hardcoded defaults for config for older providers
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #32775:
URL: https://github.com/apache/airflow/pull/32775#discussion_r1272529966
##########
airflow/configuration.py:
##########
@@ -1929,6 +1942,18 @@ def create_default_config_parser(configuration_description: dict[str, dict[str,
return parser
+def create_pre_2_7_defaults() -> ConfigParser:
+ """
+ Creates parser using the old defaults from Airflow < 2.7.0, in order to be able ot fall-back to those
Review Comment:
```suggestion
Creates parser using the old defaults from Airflow < 2.7.0, in order to be able to fall-back to those
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org