[GitHub] [hbase] openinx commented on a change in pull request #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
URL: https://github.com/apache/hbase/pull/485#discussion_r313292318
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
 ##########
 @@ -319,19 +320,22 @@ void checkTempDir(final Path tmpdir, final Configuration c, final FileSystem fs)
         HFileArchiver.archiveRegions(c, fs, this.rootdir, tableDir,
 
 Review comment:
   The archiveRegions  will archive all the hfiles and if all successfull... Then it will remains some dirs such as  <rootdir>/.tmp/data/ns/table ?   If we've deleted a namespace or table , the ns or table dir under .tmp will be also removed   (If no, the we will remain many useless dir, that's not good) ? 
   Another concern is :  if hfiles archiving failure happen and enable the snapshot acl sync,   will we remain much hfiles under the .tmp dir ?  will be storage consuming if so... maybe we need a UT ? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services