You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/20 05:33:51 UTC
[GitHub] [apisix] tzssangglass opened a new pull request, #7090: chore(ci): use the latest build script for apisix-base
tzssangglass opened a new pull request, #7090:
URL: https://github.com/apache/apisix/pull/7090
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
soulbird commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r877774956
##########
utils/linux-install-openresty.sh:
##########
@@ -26,7 +26,7 @@ sudo apt-get update
if [ "$OPENRESTY_VERSION" == "source" ]; then
cd ..
- wget https://raw.githubusercontent.com/api7/apisix-build-tools/v2.7.0/build-apisix-base.sh
+ wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh
Review Comment:
Is it possible to set branches by means of environment variable injection？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
soulbird commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r877780193
##########
utils/linux-install-openresty.sh:
##########
@@ -26,7 +26,7 @@ sudo apt-get update
if [ "$OPENRESTY_VERSION" == "source" ]; then
cd ..
- wget https://raw.githubusercontent.com/api7/apisix-build-tools/v2.7.0/build-apisix-base.sh
+ wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh
Review Comment:
This is an util script, not just for ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7090:
URL: https://github.com/apache/apisix/pull/7090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r877779379
##########
utils/linux-install-openresty.sh:
##########
@@ -26,7 +26,7 @@ sudo apt-get update
if [ "$OPENRESTY_VERSION" == "source" ]; then
cd ..
- wget https://raw.githubusercontent.com/api7/apisix-build-tools/v2.7.0/build-apisix-base.sh
+ wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh
Review Comment:
It can be done, but why should it be? The purpose of submitting this PR is to use the latest build script directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r877835136
##########
utils/linux-install-openresty.sh:
##########
@@ -26,7 +26,7 @@ sudo apt-get update
if [ "$OPENRESTY_VERSION" == "source" ]; then
cd ..
- wget https://raw.githubusercontent.com/api7/apisix-build-tools/v2.7.0/build-apisix-base.sh
+ wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh
Review Comment:
So we use the master branch by default, but other scenarios can set this variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r878850235
##########
utils/linux-install-openresty.sh:
##########
@@ -24,9 +24,11 @@ sudo add-apt-repository -y "deb https://openresty.org/package/ubuntu $(lsb_relea
sudo apt-get update
+abt_branch=${abt_branch:="master"}
Review Comment:
What does the `abt` stand for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r878883252
##########
utils/linux-install-openresty.sh:
##########
@@ -24,9 +24,11 @@ sudo add-apt-repository -y "deb https://openresty.org/package/ubuntu $(lsb_relea
sudo apt-get update
+abt_branch=${abt_branch:="master"}
Review Comment:
apisix-build-tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #7090: chore(ci): use the latest build script for apisix-base
Posted by GitBox <gi...@apache.org>.
soulbird commented on code in PR #7090:
URL: https://github.com/apache/apisix/pull/7090#discussion_r877836917
##########
utils/linux-install-openresty.sh:
##########
@@ -26,7 +26,7 @@ sudo apt-get update
if [ "$OPENRESTY_VERSION" == "source" ]; then
cd ..
- wget https://raw.githubusercontent.com/api7/apisix-build-tools/v2.7.0/build-apisix-base.sh
+ wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh
Review Comment:
Yeah, i think this is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org