[GitHub] [incubator-superset] rusackas commented on a change in pull request #9440: [WiP] Migrating unique bigNumber(total) controls

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #9440: [WiP] Migrating unique bigNumber(total) controls
URL: https://github.com/apache/incubator-superset/pull/9440#discussion_r401987346
 
 

 ##########
 File path: superset-frontend/src/explore/controlPanels/BigNumberTotal.js
 ##########
 @@ -17,6 +17,7 @@
  * under the License.
  */
 import { t } from '@superset-ui/translation';
+import { HeaderFontSize, SubheaderFontSize } from './Shared_BigNumber';
 
 Review comment:
   @kristw there are only a couple of shared controls between the two BigNumber viz modules, so I made this file to share them within that viz'package/repo. This is just a small example, but I was planning to follow the same example for the NVD3 and DeckGL modules, and consolidate shared controls that are relevant to only their repos.
   
   When we get to the SUPER commonly used controls, we could follow this pattern again, and move the "global" controls (or whatever we call it) to `superset-ui`.
   
   This also means we can still remove `controlOverrides` sectopms from the plugin control files, and do something like:
   ```
   controlSetRows: [
           [Object.assign({},HeaderFontSize,{title: 'someNewTitle'}],
         ],
   ```
   ... if that's simpler to interpret.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org