Re: [PR] Make UDTF execution framework batch processing [iotdb]

["lancelly (via GitHub)" <gi...@apache.org>]

lancelly commented on code in PR #12562:
URL: https://github.com/apache/iotdb/pull/12562#discussion_r1615385399


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TransformOperator.java:
##########
@@ -141,16 +149,31 @@ protected void initTransformers(
               .buildLayerMemoryAssigner()
               .bindInputLayerColumnIndexWithExpression()
               .buildResultColumnPointReaders()
-              .getOutputPointReaders();
+              .getOutputReaders();
     } finally {
       UDFManagementService.getInstance().releaseLock();
     }
   }
 
   protected YieldableState iterateAllColumnsToNextValid() throws Exception {
+    if (transformers.length == 1) {
+      if (outputColumns[0] == null) {
+        YieldableState state = transformers[0].yield();
+        if (state != YieldableState.YIELDABLE) {
+          return state;
+        }
+
+        Column[] columns = transformers[0].current();
+        TsBlock block = new TsBlock((TimeColumn) columns[1], columns[0]);

Review Comment:
   Why not use API wrapBlocksWithoutCopy🤔？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org