[GitHub] [spark] srowen commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r388978555
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala
 ##########
 @@ -34,12 +34,13 @@ import org.apache.spark.sql.types._
  */
 @Since("3.0.0")
 @Experimental
-class MultilabelClassificationEvaluator (override val uid: String)
+class MultilabelClassificationEvaluator @Since("3.0.0") (@Since("3.0.0") override val uid: String)
 
 Review comment:
   It's OK if it's for consistency, but if the whole class is "since 3.0" then implicitly so is everything in it. Do we really do this in a lot of the code? it just seems especially noisy to mark the constructor and then all its args this way

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org