[GitHub] rdblue commented on a change in pull request #107: Integrate encryption into datasource

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #107: Integrate encryption into datasource
URL: https://github.com/apache/incubator-iceberg/pull/107#discussion_r261715453
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/encryption/BaseEncryptionKeyMetadata.java
 ##########
 @@ -38,6 +38,6 @@ public ByteBuffer keyMetadata() {
   @Override
   public EncryptionKeyMetadata copy() {
     return new BaseEncryptionKeyMetadata(
-        ByteBuffers.copy(keyMetadata));
+        keyMetadata == null ? null : ByteBuffers.copy(keyMetadata));
 
 Review comment:
   What about making `ByteBuffers.copy` null-safe? That would prevent future problems like this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org