[jira] Commented: (TOBAGO-119) Allow custom markup - styles in

["Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/TOBAGO-119?page=comments#action_12434943 ] 
            
Bernd Bohmann commented on TOBAGO-119:
--------------------------------------

It should be possible to define the supported markup in a theme.
May be a theme has some configuration with the supported markup.

@UIcomponentTagAttribute(defaultValue = "none", propertyFile="org.apache.myfaces.tobago.theme.markup.properties", property="outMarkup");

A addional alternative could be an other tag lib (tch) for panel out in.. 
that support some cutomizing of styles and other visual decoration. 

> Allow custom markup - styles in <tc:out>
> ----------------------------------------
>
>                 Key: TOBAGO-119
>                 URL: http://issues.apache.org/jira/browse/TOBAGO-119
>             Project: MyFaces Tobago
>          Issue Type: Improvement
>          Components: Core
>         Environment: tobago 1.0.8 nightly jdk 1.4 retro
>            Reporter: Rainer Rohloff
>         Assigned To: Udo Schnurpfeil
>
> In order to guarantee CI, we need additional layout styles within the tag <tc:out>
> I think an good solution is not to limit the range of values. 
> i.e. 
>    <tc:out value="Hello world" markup="infotext1" />
> with theme-definition
>    .tobago-out-markup-infotext1 {
>       ...
>       border-bottom: 1px solid #b2b2b2;
>       ...
>    }
> possible patch ?
> public final class HtmlRendererUtil {
> if (StringUtils.isNotEmpty(markup)) {
>       if (markup.equals("strong") || markup.equals("deleted")) {
>         tobagoClass.append(prefix).append("-markup-").append(markup).append(" ");
>       } else {
>         LOG.warn("Unknown markup='" + markup + "'");
>       }
> change to:
> if (StringUtils.isNotEmpty(markup)) {
>         tobagoClass.append(prefix).append("-markup-").append(markup).append(" ");
>       if (!markup.equals("strong") && !markup.equals("deleted")) {
>         LOG.info("Not a standard markup='" + markup + "'");
> 	}
> 	  
> OutTagDeclaration:
> @UIComponentTagAttribute(defaultValue = "none", allowedValues = { "none", "strong", "deleted" })
> change to ???:
> @UIComponentTagAttribute(defaultValue = "none")

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira