You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/02/19 18:10:26 UTC
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15242
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
IMPALA-9395: fix duplicate broadcast SetFilter() calls
For broadcast join filters, we can get duplicate filters
- one set from the coordinator and one set locally.
The intent is that the first-arriving filter is used
(it's exposed to consumers via SetFilter()) and the
later filters are ignored.
This should be guaranteed by checking HasFilter()
in the same critical section as SetFilter(). I
checked all code paths in runtime-filter-bank.cc
that call SetFilter() for broadcast filters and
fixed the single exception.
Testing:
I wasn't able to reproduce this issue locally. Ran
runtime filter tests to check for regressions.
Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
---
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
2 files changed, 19 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/15242/1
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 20:55:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 16:43:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15242/1/be/src/runtime/runtime-filter-bank.cc
File be/src/runtime/runtime-filter-bank.cc:
http://gerrit.cloudera.org:8080/#/c/15242/1/be/src/runtime/runtime-filter-bank.cc@238
PS1, Line 238: // TODO: we would ideally update the coordinator logic to avoid creating duplicates
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 18:11:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5387/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 16:43:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
IMPALA-9395: fix duplicate broadcast SetFilter() calls
For broadcast join filters, we can get duplicate filters
- one set from the coordinator and one set locally.
The intent is that the first-arriving filter is used
(it's exposed to consumers via SetFilter()) and the
later filters are ignored.
This should be guaranteed by checking HasFilter()
in the same critical section as SetFilter(). I
checked all code paths in runtime-filter-bank.cc
that call SetFilter() for broadcast filters and
fixed the single exception.
Testing:
I wasn't able to reproduce this issue locally. Ran
runtime filter tests to check for regressions.
Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Reviewed-on: http://gerrit.cloudera.org:8080/15242
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
2 files changed, 19 insertions(+), 13 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5272/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 19:06:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9395: fix duplicate broadcast SetFilter() calls
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15242 )
Change subject: IMPALA-9395: fix duplicate broadcast SetFilter() calls
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d0620c4dbb5e4066702db48442cebee7389f5a
Gerrit-Change-Number: 15242
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 13:46:18 +0000
Gerrit-HasComments: No