You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/07/27 02:37:05 UTC
[GitHub] [seatunnel] Hisoka-X opened a new issue, #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Hisoka-X opened a new issue, #4736:
URL: https://github.com/apache/seatunnel/issues/4736
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues.
### What happened
At now, we add scheduler in jdbc sink #2009 , this is not an acceptable solution, we need to remove the corresponding code, because sometimes the thread pool created in the sink cannot be recycled normally.
### SeaTunnel Version
dev
### SeaTunnel Config
```conf
-
```
### Running Command
```shell
-
```
### Error Exception
```log
-
```
### Flink or Spark Version
_No response_
### Java or Scala Version
_No response_
### Screenshots
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] github-actions[bot] commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4736:
URL: https://github.com/apache/seatunnel/issues/4736#issuecomment-1624470101
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #4736:
URL: https://github.com/apache/incubator-seatunnel/issues/4736#issuecomment-1545051066
1. release the thread pool in case of exception .
2. trigger flush on checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on issue #4736:
URL: https://github.com/apache/seatunnel/issues/4736#issuecomment-1652844010
> I think checkpoint and scheduler have the same effect, so I think checkpoint can be used to replace scheduler.This keeps the code simple and reduces complexity @Hisoka-X @ic4y
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on issue #4736:
URL: https://github.com/apache/incubator-seatunnel/issues/4736#issuecomment-1548896785
> > 1. release the thread pool in case of exception .
> > 2. trigger flush on checkpoint.
>
> @zhilinli123 cc: @ic4y @Hisoka-X
Yes. Try to fix it rather than delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] github-actions[bot] closed issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
URL: https://github.com/apache/seatunnel/issues/4736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X closed issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X closed issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
URL: https://github.com/apache/seatunnel/issues/4736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] github-actions[bot] closed issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
URL: https://github.com/apache/seatunnel/issues/4736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] github-actions[bot] commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4736:
URL: https://github.com/apache/seatunnel/issues/4736#issuecomment-1612271200
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on issue #4736:
URL: https://github.com/apache/incubator-seatunnel/issues/4736#issuecomment-1545010165
cc @ic4y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on issue #4736:
URL: https://github.com/apache/incubator-seatunnel/issues/4736#issuecomment-1545016752
Assign it to me and I want to finish it thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #4736:
URL: https://github.com/apache/incubator-seatunnel/issues/4736#issuecomment-1545051404
> 1. release the thread pool in case of exception .
> 2. trigger flush on checkpoint.
@zhilinli123
cc: @ic4y @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #4736:
URL: https://github.com/apache/seatunnel/issues/4736#issuecomment-1652843220
> > > 1. release the thread pool in case of exception .
> > > 2. trigger flush on checkpoint.
> >
> >
> > @zhilinli123 cc: @ic4y @Hisoka-X
>
> Yes. Try to fix it rather than delete it.
I think checkpoint and scheduler have the same effect, so I think checkpoint can be used to replace scheduler.This keeps the code simple and reduces complexity @Hisoka-X @ic4y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] github-actions[bot] commented on issue #4736: [Bug] [Connector-V2] Remove scheduler in JDBC sink
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4736:
URL: https://github.com/apache/seatunnel/issues/4736#issuecomment-1593881106
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org