You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Paco Avila (JIRA)" <ji...@apache.org> on 2009/02/09 10:19:00 UTC
[jira] Created: (JCR-1972) Preserving UUID and document version
history on repository migration
Preserving UUID and document version history on repository migration
--------------------------------------------------------------------
Key: JCR-1972
URL: https://issues.apache.org/jira/browse/JCR-1972
Project: Jackrabbit Content Repository
Issue Type: Wish
Components: jackrabbit-core
Affects Versions: core 1.4.8
Reporter: Paco Avila
I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCR-1972) Preserving UUID and
document version history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731866#action_12731866 ]
Paco Avila edited comment on JCR-1972 at 7/16/09 2:06 AM:
----------------------------------------------------------
Updated patch -> Check for existing UUID.
I have to duplicate some methods to add a new parameter with the UUID.
was (Author: monkiki):
Updated patch -> Check for existing UUID
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1972:
-------------------------------
Status: Patch Available (was: Open)
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Attachment: JCR-1972_1.x.patch
Improvements by recommendation of Jukka
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729069#action_12729069 ]
Paco Avila commented on JCR-1972:
---------------------------------
As I wrote some time ago, these modifications make two enhacements in the jackrabbit-core functionality:
- Enable UUID parameter in addNode: this allow to preserve the unique node identifier across a repository migration. If you use references this change is fundamental.
- Enable Calendar parameter in checkin: this change can be used to preserve checking date in document version history in a possible migration.
This migration can be of two types:
- Change the repository backend: you use the default Derby database, but you want to swith to MySQL, for example. Actually this is not possible in a easy way.
- Change the repository node definitions: jackrabbit actually can't deal with these changes depending on their complexity. You have to write a program to make this migration.
>From my point of view, this patch introduces very neccessary funtionality into Jackrabbit. If you want to include these modifications in a near release, I can try to send a new patch that works with an specific jackrabbit-core version.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Attachment: JCR-1972_1.x.patch
Updated patch for the 1.x branch
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730818#action_12730818 ]
Jukka Zitting commented on JCR-1972:
------------------------------------
The patch is creating lots of duplicate code in the extra methods. Can we avoid that?
Also, it would be good to have a check to prevent someone to add a new node with an id that already exists in the workspace.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729961#action_12729961 ]
Jukka Zitting commented on JCR-1972:
------------------------------------
We should protect against the case of adding a node with an UUID that already exists in the workspace. See the XML import functionality for potential ways of dealing with such cases.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738363#action_12738363 ]
Jukka Zitting commented on JCR-1972:
------------------------------------
One more thing... Your patch referenced a CheckinCalendarTest class, but the relevant java file wasn't included in the patch. Can you attach the file so we can include it in the test suite?
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-1972.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.6.0
The new method signatures are now available also in trunk. Resolving as fixed for 1.6.0.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Fix For: 1.6.0
>
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting reassigned JCR-1972:
----------------------------------
Assignee: Jukka Zitting
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1972:
-------------------------------
Status: Open (was: Patch Available)
If I read the patch correctly, it breaks the NodeImpl.checkin() method.
Also, please use only spaces (no tabs) for indentation.
Other than that I think the changes are reasonable. We may even want to consider adding the extra method signatures to jackrabbit-api.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1972:
-------------------------------
Attachment: JCR-1972_1.x.patch
Thanks! I made some modifications to the patch (no tabs, less extra methods, even less code duplication; see attached patch for details) and committed it to the 1.x branch in revision 800385.
I'll see what it takes to forward port this to the trunk.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730304#action_12730304 ]
Paco Avila commented on JCR-1972:
---------------------------------
In 1.x branch, the class org.apache.jackrabbit.core.NodeImpl.java is this:
public synchronized NodeImpl addNode(Name nodeName, Name nodeTypeName, UUID uuid)
So, it already accept an UUID parameter for new node creation.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Attachment: Jackrabbit_modifications.pdf
This PDF shows the modifications needed in the jackrabbit core to preserve node UUID and document version history date in repository migrations.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671808#action_12671808 ]
Alexander Klimetschek commented on JCR-1972:
--------------------------------------------
Could you provide the diff in a normal txt/patch format (svn diff > JCR-1972.patch)? A pdf is a rather unusual format for that ;-)
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCR-1972) Preserving UUID and
document version history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671842#action_12671842 ]
monkiki edited comment on JCR-1972 at 2/9/09 5:10 AM:
---------------------------------------------------------
Patch solicited by Alexander Klimetschek. This patch works with jackrabbit-core-1.4.6 and i'm not sure if it works for more recent versions.
was (Author: monkiki):
Patch solicited by Alexander Klimetschek. This patch works with jackrabbit-core-1.4.6
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732525#action_12732525 ]
Jukka Zitting commented on JCR-1972:
------------------------------------
Thanks for the update! Still more comments:
* It would be better if the UUID argument was a String instead of an instance of the UUID class. Also, it might be useful to rename the relevant methods to addNodeWithUUUID to avoid signature clashes with the already overloaded addNode method.
* It would be good to have javadocs for all the new methods.
* Please use only spaces to indent the code.
* About the duplicate methods: It's OK to have extra method signatures for different purposes, but now you're duplicating also the entire method bodies. For example the new NodeImpl.checkin(Calendar) method is some 40 lines of code that's essentially identical to the code in NodeImpl.checkin(). If we later on encounter a bug and fix it in the checkin() method, how do we make sure that the fix also gets applied to checkin(Calendar)?
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Attachment: JCR-1972_1.x.patch
Check for existing UUID
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Comment: was deleted
(was: In 1.x branch, the class org.apache.jackrabbit.core.NodeImpl.java is this:
public synchronized NodeImpl addNode(Name nodeName, Name nodeTypeName, UUID uuid)
So, it already accept an UUID parameter for new node creation.)
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Attachment: JCR-1972.patch
Patch solicited by Alexander Klimetschek. This patch works with jackrabbit-core-1.4.6
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730372#action_12730372 ]
Paco Avila commented on JCR-1972:
---------------------------------
I've updated the patch and also added two JUnit test (CheckinCalendarTest and added a new method at NodeImplTest).
In addNode(..., UUID) I can test if the node has the MIX_REFERENCEABLE mixing but I'm not sure if this good because the mixin can be added after the node creation. This check is commented in the patch.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paco Avila updated JCR-1972:
----------------------------
Attachment: CheckinCalendarTest.java
The missing test class
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Fix For: 1.6.0
>
> Attachments: CheckinCalendarTest.java, Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1972) Preserving UUID and document version
history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738544#action_12738544 ]
Paco Avila commented on JCR-1972:
---------------------------------
Sorry for the missing test class. I did no review of the generated patch and thought it was included. I'm on holiday but i will try to get a decent Internet connection to attach the missing class.
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Assignee: Jukka Zitting
> Fix For: 1.6.0
>
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCR-1972) Preserving UUID and
document version history on repository migration
Posted by "Paco Avila (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731866#action_12731866 ]
Paco Avila edited comment on JCR-1972 at 7/16/09 2:05 AM:
----------------------------------------------------------
Updated patch -> Check for existing UUID
was (Author: monkiki):
Check for existing UUID
> Preserving UUID and document version history on repository migration
> --------------------------------------------------------------------
>
> Key: JCR-1972
> URL: https://issues.apache.org/jira/browse/JCR-1972
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Affects Versions: core 1.4.8
> Reporter: Paco Avila
> Attachments: Jackrabbit_modifications.pdf, JCR-1972.patch, JCR-1972_1.x.patch, JCR-1972_1.x.patch
>
>
> I have been working I an migration utility for OpenKM and I performed some changes in jackrabit-core to enable version import, preserving
> the modification date. Also modified org.apache.jackrabbit.core.NodeImpl to preserve UUID in the migration process.
> This migration process is needed because there are changes in repository node definition, and Jackrabbit can't deal with this actually.
> I've attache a PDF with the changes needed in Jackrabbit-core. It works and there was no problems with the migrated repository.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.