You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2016/04/13 05:09:20 UTC
[GitHub] spark pull request: [SPARK-14109][SQL] Fix HDFSMetadataLog to fall...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11925#discussion_r59487598
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ---
@@ -196,4 +195,148 @@ class HDFSMetadataLog[T: ClassTag](sqlContext: SQLContext, path: String)
}
None
}
+
+ private def createFileManager(): FileManager = {
+ val hadoopConf = sqlContext.sparkContext.hadoopConfiguration
+ try {
+ new FileContextManager(metadataPath, hadoopConf)
+ } catch {
+ case e: UnsupportedFileSystemException =>
+ logWarning("Could not use FileContext API for managing metadata log file. The log may be" +
+ "inconsistent under failures.", e)
--- End diff --
Can we remove this stack trace? Its not helpful (the error is always thrown from `createFileSystem`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org