You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/04 09:33:39 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #10316:
[FLINK-14624][table-blink] Support computed column as rowtime attribute
KurtYoung commented on a change in pull request #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#discussion_r353598268
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java
##########
@@ -337,6 +337,8 @@ private TableSchema createTableSchema(SqlCreateTable sqlCreateTable) {
SqlNode validatedExpr = validator
.validateParameterizedExpression(call.operand(0), nameToType);
final RelDataType validatedType = validator.getValidatedNodeType(validatedExpr);
+ String fieldName = call.operand(1).toString();
+ nameToType.put(fieldName, validatedType);
Review comment:
If you add this to here, we will let some invalid usage pass here, like one computed column depends on another computed column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services