You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/30 23:26:13 UTC
Review Request 17558: Fixed the flaky Os.killtree test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17558/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-927
https://issues.apache.org/jira/browse/MESOS-927
Repository: mesos-git
Description
-------
It seems like arbitrary sleeps in this test can cause rare test failures on slower VMs running CI. The tests now run faster and will fail if expectations are not met within 10 seconds.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp c40c7432c06528e21157ff50e3bf19fb90a66429
Diff: https://reviews.apache.org/r/17558/diff/
Testing
-------
Ran with 10,000 iterations on OS X and 30,000 iterations on Linux.
Thanks,
Ben Mahler
Re: Review Request 17558: Fixed the flaky Os.killtree test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17558/#review33268
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 30, 2014, 10:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17558/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 10:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-927
> https://issues.apache.org/jira/browse/MESOS-927
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> It seems like arbitrary sleeps in this test can cause rare test failures on slower VMs running CI. The tests now run faster and will fail if expectations are not met within 10 seconds.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp c40c7432c06528e21157ff50e3bf19fb90a66429
>
> Diff: https://reviews.apache.org/r/17558/diff/
>
>
> Testing
> -------
>
> Ran with 10,000 iterations on OS X and 30,000 iterations on Linux.
>
>
> Thanks,
>
> Ben Mahler
>
>