You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/09/29 02:23:17 UTC
[I] Node SDK: wire up snapshot [iggy]
justinmclean opened a new issue, #4331:
URL: https://github.com/apache/iggy/issues/4331
The Rust client has `SystemClient::snapshot` (`core/common/src/traits/system_client.rs`), which returns a compressed snapshot of server state for debugging. It is the only client call the Node SDK does not have. The command code is already in `foreign/node/src/wire/command.code.ts` (`GetSnapshot: 11`, marked `@TODO`), but nothing uses it.
## What to do
- Add `foreign/node/src/wire/system/snapshot.command.ts`, following `get-stats.command.ts` in the same folder. The request and response formats are in `core/binary_protocol/src/requests/system/get_snapshot.rs` and `core/binary_protocol/src/responses/system/get_snapshot.rs`.
- Export it from `system/index.ts` and register it in `foreign/node/src/wire/command-set.ts` next to `getStats`.
- Remove the `@TODO` on the `GetSnapshot` entry.
- Add a unit test for the serialisation, and an e2e test in `foreign/node/src/e2e/tcp.raw.e2e.ts` next to the `getStats` one.
## Done when
`snapshot` returns a non-empty result against a running server, and the new tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Node SDK: wire up snapshot [iggy]
Posted by "rk-roshan-kr (via GitHub)" <gi...@apache.org>.
rk-roshan-kr commented on issue #4331:
URL: https://github.com/apache/iggy/issues/4331#issuecomment-5955749502
Hi @justinmclean @hubcio, I would like to work on this issue. Could you please assign it to me?
**Plan:**
- Add `foreign/node/src/wire/system/snapshot.command.ts` implementing the binary wire protocol (`[compression:1][types_count:1][snapshot_type:1]*`) and handling the raw ZIP archive response.
- Export it from `system/index.ts` and register it in `command-set.ts` under `systemAPI` next to `getStats`.
- Remove the `@TODO` on command code 11 in `command.code.ts`.
- Add serialization/deserialization unit tests in `snapshot.command.test.ts` and integration checks in `tcp.raw.e2e.ts`.
I have the implementation, unit tests, and TypeScript builds verified locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Node SDK: wire up snapshot [iggy]
Posted by "slbotbm (via GitHub)" <gi...@apache.org>.
slbotbm closed issue #4331: Node SDK: wire up snapshot
URL: https://github.com/apache/iggy/issues/4331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Node SDK: wire up snapshot [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on issue #4331:
URL: https://github.com/apache/iggy/issues/4331#issuecomment-5896004265
read CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Node SDK: wire up snapshot [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on issue #4331:
URL: https://github.com/apache/iggy/issues/4331#issuecomment-5955915983
@rk-roshan-kr assigned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Node SDK: wire up snapshot [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed issue #4331: Node SDK: wire up snapshot
URL: https://github.com/apache/iggy/issues/4331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org