[GitHub] [netbeans] eirikbakke commented on issue #1278: [NETBEANS-2604] Support SVG icon loading from ImageUtilities

[GitBox <gi...@apache.org>]

eirikbakke commented on issue #1278: [NETBEANS-2604] Support SVG icon loading from ImageUtilities
URL: https://github.com/apache/netbeans/pull/1278#issuecomment-538471734
 
 
   Hearing no objections, I ended up going back to the 3-module approach, since the more general IconLoader approach turned out to be more complex (see my previous post).
   
   Today's commits should address the remaining issues. Most notably, the SVG loader module and the associated Batik libraries have been moved out of the platform cluster, and verified to be actually optional. When the SVG module is present, ImageUtilities supports loading of explicitly named SVG files. Additionally, attempting to load "icon.png" will load "icon.svg" instead if the latter file is present in the same location. This will allow SVG icons to be added to NetBeans libraries without breaking compatibility with platform applications that do not wish to add a dependency on the SVG loader module.
   
   (One of the 12 Travis checks fail, but I think it's unrelated to these commits, since it's a mysql-related thing.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists