[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #274: HTTPCORE-671: URIBuilder does not precent-encode bracketed IPv6 addre…

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #274:
URL: https://github.com/apache/httpcomponents-core/pull/274#discussion_r601238087



##########
File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
##########
@@ -292,6 +292,8 @@ private String buildString() {
                 }
                 if (InetAddressUtils.isIPv6Address(this.host)) {
                     sb.append("[").append(this.host).append("]");
+                } else if (InetAddressUtils.isIPv6URLBracketedAddress(this.host)) {

Review comment:
       I consider that this is logically wrong. The provided host is URI agnostic because the brackets are a URI problem not a host one. For me a host of `[::1]` as input is invalid.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org