You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/03/08 19:43:23 UTC
Re: svn commit: r1079070 - /subversion/trunk/subversion/libsvn_subr/sqlite.c
On Mon, Mar 7, 2011 at 20:33, <hw...@apache.org> wrote:
> Author: hwright
> Date: Tue Mar 8 01:33:03 2011
> New Revision: 1079070
>
> URL: http://svn.apache.org/viewvc?rev=1079070&view=rev
> Log:
> If we encounter an error while in an SQLite savepoint, back out the work
> before returning. This mirrors the behavior as seen in an SQLite transaction.
And it copies the code. How about factoring out "reset all statements" ?
Cheers,
-g
Re: svn commit: r1079070 - /subversion/trunk/subversion/libsvn_subr/sqlite.c
Posted by Hyrum K Wright <hy...@hyrumwright.org>.
On Tue, Mar 8, 2011 at 12:43 PM, Greg Stein <gs...@gmail.com> wrote:
> On Mon, Mar 7, 2011 at 20:33, <hw...@apache.org> wrote:
>> Author: hwright
>> Date: Tue Mar 8 01:33:03 2011
>> New Revision: 1079070
>>
>> URL: http://svn.apache.org/viewvc?rev=1079070&view=rev
>> Log:
>> If we encounter an error while in an SQLite savepoint, back out the work
>> before returning. This mirrors the behavior as seen in an SQLite transaction.
>
> And it copies the code. How about factoring out "reset all statements" ?
It's really a small snippet, and I usually defer factoring stuff out
until it is thrice repeated, but I'll make an exception here for you.
:) r1079538.
-Hyrum