You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/07/30 04:01:05 UTC

[GitHub] [cordova-docs] erisu opened a new pull request #1183: doc: add android 10.0.1 release blog post

erisu opened a new pull request #1183:
URL: https://github.com/apache/cordova-docs/pull/1183


   ### Motivation and Context
   
   Cordova-Android 10.0.1 Release Blog Post
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] erisu merged pull request #1183: doc: add android 10.0.1 release blog post

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1183:
URL: https://github.com/apache/cordova-docs/pull/1183


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] dpogue commented on a change in pull request #1183: doc: add android 10.0.1 release blog post

Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #1183:
URL: https://github.com/apache/cordova-docs/pull/1183#discussion_r679636424



##########
File path: www/_posts/2021-07-30-cordova-android-10.0.1.md
##########
@@ -0,0 +1,68 @@
+---
+layout: post
+author:
+    name: Bryan Ellis
+title:  "Cordova Android 10.0.1 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 10.0.1`!  This is one of Cordova's supported platforms for building Android mobile applications.
+
+* [cordova-android@10.0.1](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@10.0.1
+```
+
+## Release Highlights
+
+In this patch release, we had fixed three reported issues that caused build issues.
+
+* **Fixed `GradlePluginGoogleServicesEnabled` Invalid Version Error**
+
+Projects that set the `GradlePluginGoogleServicesEnabled` config flag to `true` saw an invalid version error. The error was caused by the build process reading a bad variable reference. 
+
+We corrected the variable reference and fixed this issue.
+
+* **Fixed Incorrect Fetching of Latest Build Tools:**

Review comment:
       No colon at the end of the bullet point

##########
File path: www/_posts/2021-07-30-cordova-android-10.0.1.md
##########
@@ -0,0 +1,68 @@
+---
+layout: post
+author:
+    name: Bryan Ellis
+title:  "Cordova Android 10.0.1 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 10.0.1`!  This is one of Cordova's supported platforms for building Android mobile applications.
+
+* [cordova-android@10.0.1](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@10.0.1
+```
+
+## Release Highlights
+
+In this patch release, we had fixed three reported issues that caused build issues.
+
+* **Fixed `GradlePluginGoogleServicesEnabled` Invalid Version Error**
+
+Projects that set the `GradlePluginGoogleServicesEnabled` config flag to `true` saw an invalid version error. The error was caused by the build process reading a bad variable reference. 
+
+We corrected the variable reference and fixed this issue.

Review comment:
       I don't think we need to say how things were fixed, unless there are new instructions that end users need to be aware of

##########
File path: www/_posts/2021-07-30-cordova-android-10.0.1.md
##########
@@ -0,0 +1,68 @@
+---
+layout: post
+author:
+    name: Bryan Ellis
+title:  "Cordova Android 10.0.1 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 10.0.1`!  This is one of Cordova's supported platforms for building Android mobile applications.
+
+* [cordova-android@10.0.1](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@10.0.1
+```
+
+## Release Highlights
+
+In this patch release, we had fixed three reported issues that caused build issues.
+
+* **Fixed `GradlePluginGoogleServicesEnabled` Invalid Version Error**
+
+Projects that set the `GradlePluginGoogleServicesEnabled` config flag to `true` saw an invalid version error. The error was caused by the build process reading a bad variable reference. 
+
+We corrected the variable reference and fixed this issue.
+
+* **Fixed Incorrect Fetching of Latest Build Tools:**
+
+Users who have installed build tools 31.x noticed Cordova attempting to use the newer build tools by default.
+
+By default, Cordova-Android 10.x tries to fetch the latest installed build tools, but it should be only selecting within the supported major release range.
+
+For example, Cordova-Android 10.x supports SDK build tools 30.0.3. If a newer version of build tools within 30.x was released and installed, Cordova should fetch and use it. If the environment has 31.x or higher, those should be ignored. 
+
+Newer major release versions are not tested and may not be compatible with Cordova.
+
+We corrected this by ensuring that only within the supported major range was being discovered and used.
+
+* **Fixed Issue with Pinning Build Tools:**

Review comment:
       Remove trailing colon and reword: **Fixed building with pinned build tools**

##########
File path: www/_posts/2021-07-30-cordova-android-10.0.1.md
##########
@@ -0,0 +1,68 @@
+---
+layout: post
+author:
+    name: Bryan Ellis
+title:  "Cordova Android 10.0.1 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 10.0.1`!  This is one of Cordova's supported platforms for building Android mobile applications.

Review comment:
       Maybe say something here about this being a bugfix update.

##########
File path: www/_posts/2021-07-30-cordova-android-10.0.1.md
##########
@@ -0,0 +1,68 @@
+---
+layout: post
+author:
+    name: Bryan Ellis
+title:  "Cordova Android 10.0.1 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 10.0.1`!  This is one of Cordova's supported platforms for building Android mobile applications.
+
+* [cordova-android@10.0.1](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@10.0.1
+```
+
+## Release Highlights
+
+In this patch release, we had fixed three reported issues that caused build issues.
+
+* **Fixed `GradlePluginGoogleServicesEnabled` Invalid Version Error**
+
+Projects that set the `GradlePluginGoogleServicesEnabled` config flag to `true` saw an invalid version error. The error was caused by the build process reading a bad variable reference. 

Review comment:
       Indent these paragraphs by 2 spaces so  that they end up nested under the bullet points




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org