You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/01 00:15:27 UTC
[GitHub] [netbeans] SiddheshRane opened a new pull request #2286: [NETBEANS-4667] Fix broken npm search
SiddheshRane opened a new pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286
IDE npm search (Web project > properties > npm > add) is broken due to output format change in npm.
This commit uses npm --parseable flag to fix and simplify output parsing.
Tested with npm 6.14.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-694170083
From my pov it looks promising :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] SiddheshRane commented on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
SiddheshRane commented on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-667566012
The `--parseable` flag was added to npm search around 4 years ago. Before that it was named `--tab-seperated`. So I think it covers a lot of npm versions that people are actually using.
This is a general fix for scraping cli output as was meant to be done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-667533729
Cool, finally :). I had a look into the code, you removed a lot. So is this fix a general fix and will this work for those who not uses npm >= 6?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
Chris2011 edited a comment on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-667533870
Also we should get rid of those hardcoded flags. But this is another task. Thx for your work :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-667568247
Ok great. Thx for the info :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-694885621
Thank you - change looks sane, unittests come back clean, author information looks good.
@SiddheshRane I assume, that you agree that the changeset is donated to the ASF, if that is not the case, please say so, the merge will then be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2286: [NETBEANS-4667] Fix broken npm search
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2286:
URL: https://github.com/apache/netbeans/pull/2286#issuecomment-667533870
Also we should get rid of those hardcoded flags. But this is another task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists