[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3748: fixes bug where lock is not unlocked on exception

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3748:
URL: https://github.com/apache/accumulo/pull/3748#discussion_r1322162813


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1889,6 +1889,8 @@ public void checkIfMinorCompactionNeededForLogs(List<DfsLogger> closedLogs) {
     }
   }
 
+  @SuppressFBWarnings(value = "UL_UNRELEASED_LOCK",
+      justification = "lock is released by caller calling finishClearingUnusedLogs method")

Review Comment:
   If the caller is responsible for releasing it, then shouldn't the caller catch the RTE and release it in the calling code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org