You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Günter Knauf <ef...@gmx.net> on 2004/02/05 01:53:09 UTC
[PATCH] uri runtime info - avoid nameless entries
Hi all,
in mod_jk2, if invoked by the /jkstatus page, jk2_worker_status_displayRuntimeType() displays always a nameless / useless first line below the uri runtime info;
I'm asking me what entry that vould be, and if it is the right way to suppress displaying it, or dig for what it is?
can perhaps someone enlighten me?
======================================================
--- jk_worker_status.c.orig Tue Feb 03 00:21:34 2004
+++ jk_worker_status.c Wed Feb 04 22:03:24 2004
@@ -282,6 +282,10 @@
if( mbean==NULL || mbean->getAttributeInfo==NULL )
continue;
+ /* Don't display nameless */
+ if( mbean->localName == NULL || (strlen(mbean->localName) == 0) )
+ continue;
+
if( mbean->getAttribute == NULL )
continue;
thanks, Guenter.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] uri runtime info - avoid nameless entries
Posted by Henri Gomez <hg...@apache.org>.
Günter Knauf a écrit :
> Hi all,
> no comments yet to this??
> Guenter.
>
>
>>in mod_jk2, if invoked by the /jkstatus page,
>>jk2_worker_status_displayRuntimeType() displays always a nameless /
>>useless first line below the uri runtime info;
>>I'm asking me what entry that vould be, and if it is the right way to
>>suppress displaying it, or dig for what it is?
>>can perhaps someone enlighten me?
>
>
>>======================================================
>>--- jk_worker_status.c.origTue Feb 03 00:21:34 2004
>>+++ jk_worker_status.c Wed Feb 04 22:03:24 2004
>>@@ -282,6 +282,10 @@
>> if( mbean==NULL || mbean->getAttributeInfo==NULL )
>> continue;
>
>
>>+ /* Don't display nameless */
>>+ if( mbean->localName == NULL || (strlen(mbean->localName) == 0) )
>>+ continue;
>>+
>> if( mbean->getAttribute == NULL )
>> continue;
Make sense, commited, thanks
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] uri runtime info - avoid nameless entries
Posted by Costin Manolache <cm...@yahoo.com>.
NormW wrote:
> Good morning All.
> The fact that the row (without even a 'name' value) appears in the URI
> runtime table in /jkstatus suggests that it must be an object (bean?) of
> type 'uri' because that is a requirement of the loop. Hence something is
> permitting the creation of an unitialised uri object [zero perhaps, since it
> is the first element in the table] and all this change will do is mask it
> from display in /jkstatus. Of course once the cause of the problem is
> determined then this patch will not have a detrimental effect.
If I remember correctly, this object is created by the initialization
process of apache - there is a callback for each <Location> and <Host>,
but also one callback for the top-level server, with no location or host.
I think it can be avoided, don't remember any use for this.
Costin
> Norm
>
>
>>Hi all,
>>no comments yet to this??
>>Guenter.
>>
>>
>>>in mod_jk2, if invoked by the /jkstatus page,
>>>jk2_worker_status_displayRuntimeType() displays always a nameless /
>>>useless first line below the uri runtime info;
>>>I'm asking me what entry that vould be, and if it is the right way to
>>>suppress displaying it, or dig for what it is?
>>>can perhaps someone enlighten me?
>>
>>>======================================================
>>>--- jk_worker_status.c.origTue Feb 03 00:21:34 2004
>>>+++ jk_worker_status.c Wed Feb 04 22:03:24 2004
>>>@@ -282,6 +282,10 @@
>>> if( mbean==NULL || mbean->getAttributeInfo==NULL )
>>> continue;
>>
>>>+ /* Don't display nameless */
>>>+ if( mbean->localName == NULL || (strlen(mbean->localName) ==
>
> 0) )
>
>>>+ continue;
>>>+
>>> if( mbean->getAttribute == NULL )
>>> continue;
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] uri runtime info - avoid nameless entries
Posted by NormW <no...@bocnet.com.au>.
Good morning All.
The fact that the row (without even a 'name' value) appears in the URI
runtime table in /jkstatus suggests that it must be an object (bean?) of
type 'uri' because that is a requirement of the loop. Hence something is
permitting the creation of an unitialised uri object [zero perhaps, since it
is the first element in the table] and all this change will do is mask it
from display in /jkstatus. Of course once the cause of the problem is
determined then this patch will not have a detrimental effect.
Norm
> Hi all,
> no comments yet to this??
> Guenter.
>
> > in mod_jk2, if invoked by the /jkstatus page,
> > jk2_worker_status_displayRuntimeType() displays always a nameless /
> > useless first line below the uri runtime info;
> > I'm asking me what entry that vould be, and if it is the right way to
> > suppress displaying it, or dig for what it is?
> > can perhaps someone enlighten me?
>
> > ======================================================
> > --- jk_worker_status.c.origTue Feb 03 00:21:34 2004
> > +++ jk_worker_status.c Wed Feb 04 22:03:24 2004
> > @@ -282,6 +282,10 @@
> > if( mbean==NULL || mbean->getAttributeInfo==NULL )
> > continue;
>
> > + /* Don't display nameless */
> > + if( mbean->localName == NULL || (strlen(mbean->localName) ==
0) )
> > + continue;
> > +
> > if( mbean->getAttribute == NULL )
> > continue;
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] uri runtime info - avoid nameless entries
Posted by Günter Knauf <ef...@gmx.net>.
Hi all,
no comments yet to this??
Guenter.
> in mod_jk2, if invoked by the /jkstatus page,
> jk2_worker_status_displayRuntimeType() displays always a nameless /
> useless first line below the uri runtime info;
> I'm asking me what entry that vould be, and if it is the right way to
> suppress displaying it, or dig for what it is?
> can perhaps someone enlighten me?
> ======================================================
> --- jk_worker_status.c.origTue Feb 03 00:21:34 2004
> +++ jk_worker_status.c Wed Feb 04 22:03:24 2004
> @@ -282,6 +282,10 @@
> if( mbean==NULL || mbean->getAttributeInfo==NULL )
> continue;
> + /* Don't display nameless */
> + if( mbean->localName == NULL || (strlen(mbean->localName) == 0) )
> + continue;
> +
> if( mbean->getAttribute == NULL )
> continue;
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org