You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/05/14 06:07:34 UTC

[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

qiuchenjian commented on a change in pull request #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap
URL: https://github.com/apache/carbondata/pull/3072#discussion_r283637500
 
 

 ##########
 File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/util/BirdcageOptimizer.scala
 ##########
 @@ -132,7 +133,9 @@ object BirdcageOptimizer extends RuleExecutor[LogicalPlan] {
     Batch(
       "RewriteSubquery", Once,
       RewritePredicateSubquery,
-      CollapseProject) :: Nil
+      CollapseProject) ::
+    Batch(
+      "MVProjectAdd", Once, MVProjectColumnsAdd)::Nil
 
 Review comment:
   @ravipesala  modify as zhxiaoping says,  please review again

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services