[jira] [Commented] (TOBAGO-1318) Meaning of TobagoConfig.isCheckSessionSecret() and isCreateSessionSecret() is inverted

["Hudson (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TOBAGO-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789041#comment-13789041 ] 

Hudson commented on TOBAGO-1318:
--------------------------------

SUCCESS: Integrated in tobago-1.5.x #189 (See [https://builds.apache.org/job/tobago-1.5.x/189/])
TOBAGO-1318: Meaning of TobagoConfig.isCheckSessionSecret() and isCreateSessionSecret() is inverted (lofwyr: http://svn.apache.org/viewvc/?view=rev&rev=1530175)
* /myfaces/tobago/branches/tobago-1.5.x/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/SecretSessionListener.java
* /myfaces/tobago/branches/tobago-1.5.x/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/PageRenderer.java


> Meaning of TobagoConfig.isCheckSessionSecret() and isCreateSessionSecret() is inverted
> --------------------------------------------------------------------------------------
>
>                 Key: TOBAGO-1318
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1318
>             Project: MyFaces Tobago
>          Issue Type: Bug
>    Affects Versions: 1.0.40, 1.5.10, 2.0.0-alpha-2
>            Reporter: Udo Schnurpfeil
>            Assignee: Udo Schnurpfeil
>            Priority: Minor
>
> Both values are true by default and both value are the same for most applications, so the problem shoudn't be so large.
> Correct is:
> * create() will be called, if isCreate is set
> * encode() will be called, if isCheck is set
> * check() will be called, if isCheck is set



--
This message was sent by Atlassian JIRA
(v6.1#6144)