[GitHub] [ambari] bhavikpatel9977 commented on a diff in pull request #3364: AMBARI-25729: Add support for Mysql 8.x

[GitBox <gi...@apache.org>]

bhavikpatel9977 commented on code in PR #3364:
URL: https://github.com/apache/ambari/pull/3364#discussion_r988613272


##########
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql:
##########
@@ -26,16 +26,6 @@ delimiter ;
 
 # USE @schema;
 
--- Set default_storage_engine to InnoDB
--- storage_engine variable should be used for versions prior to MySQL 5.6
-set @version_short = substring_index(@@version, '.', 2);
-set @major = cast(substring_index(@version_short, '.', 1) as SIGNED);
-set @minor = cast(substring_index(@version_short, '.', -1) as SIGNED);
-set @engine_stmt = IF(@major >= 5 AND @minor>=6, 'SET default_storage_engine=INNODB', 'SET storage_engine=INNODB');
-prepare statement from @engine_stmt;
-execute statement;
-DEALLOCATE PREPARE statement;
-

Review Comment:
   There will be an prerequisite that admin has to set mysql default engine to INNODB.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org