You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/08/14 17:45:28 UTC

[jira] [Created] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

[patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done
-----------------------------------------------------------------------------------------------------

                 Key: CASSANDRA-3034
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.8.4
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: 0.8.5
         Attachments: skip_fully.diff

code calls skip(remaining) without checking result. Skip isn't guaranteed to skip what you requested, especially BufferedInputStream, so keep skipping until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-3034.
---------------------------------------

    Resolution: Fixed

committed, thanks!

> [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3034
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.0
>
>         Attachments: skip_fully.diff
>
>
> code calls skip(remaining) without checking result. Skip isn't guaranteed to skip what you requested, especially BufferedInputStream, so keep skipping until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3034:
--------------------------------------

             Reviewer: jbellis
    Affects Version/s:     (was: 0.8.4)
                       1.0
        Fix Version/s:     (was: 0.8.5)
                       1.0
             Assignee: Dave Brosius

> [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3034
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.0
>
>         Attachments: skip_fully.diff
>
>
> code calls skip(remaining) without checking result. Skip isn't guaranteed to skip what you requested, especially BufferedInputStream, so keep skipping until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated CASSANDRA-3034:
------------------------------------

    Attachment: skip_fully.diff

> [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3034
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.4
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 0.8.5
>
>         Attachments: skip_fully.diff
>
>
> code calls skip(remaining) without checking result. Skip isn't guaranteed to skip what you requested, especially BufferedInputStream, so keep skipping until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira