[GitHub] [pulsar] eolivelli commented on a diff in pull request #15751: PIP-105 add support for updating the Subscription properties

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #15751:
URL: https://github.com/apache/pulsar/pull/15751#discussion_r888688990


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1527,6 +1527,43 @@ public void resetCursor(
         }
     }
 
+    @POST
+    @Path("/{tenant}/{namespace}/{topic}/subscription/{subName}/updateProperties")

Review Comment:
   I have switched to PUT, thanks
   for GET I would prefer to do a follow up PR, as the information is already available in stats and I would prefer to keep the patch as small as possible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org