[GitHub] Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

[GitBox <gi...@apache.org>]

Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r221179438
 
 

 ##########
 File path: docs/_includes/generated/job_manager_configuration.html
 ##########
 @@ -27,6 +27,11 @@
             <td style="word-wrap: break-word;">"1024m"</td>
             <td>JVM heap size for the JobManager.</td>
         </tr>
+        <tr>
+            <td><h5>jobmanager.metric-query-service.rpc.port</h5></td>
+            <td style="word-wrap: break-word;">6124</td>
+            <td>The config parameter defining the network port to connect to for communication with the job manager's metric query service. Like jobmanager.rpc.address, this value is only interpreted in setups where a single JobManager with static name/address and port exists (simple standalone setups, or container setups with dynamic service name resolution). This config option is not used in many high-availability setups, when a leader-election service (like ZooKeeper) is used to elect and discover the JobManager leader from potentially multiple standby JobManagers.</td>
 
 Review comment:
   I copied this from descrption of jobmanager.rpc.port. No grammer problem here but seems fine to remove them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services