[jira] [Commented] (AIRFLOW-3773) /refresh_all fails with TypeError

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753174#comment-16753174 ] 

ASF GitHub Bot commented on AIRFLOW-3773:
-----------------------------------------

astahlman commented on pull request #4597: [AIRFLOW-3773] Fix /refresh_all endpoint
URL: https://github.com/apache/airflow/pull/4597
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3773
   
   ### Description
   
   - [ X ] Here are some details about my PR, including screenshots of any UI changes:
   
   Call `sync_perm_for_dag` for each DAG in the DagBag (`dag_id` is a
   required argument).
   
   ### Tests
   
   - [ X ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   I looked for a test suite for the web UI, but it seems the existing
   tests have all been disabled since the switch to FAB. I've created a new
   class for FAB tests and added a test to exercise the `/refresh_all`
   endpoint.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ X ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> /refresh_all fails with TypeError 
> ----------------------------------
>
>                 Key: AIRFLOW-3773
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3773
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Andrew Stahlman
>            Assignee: Andrew Stahlman
>            Priority: Major
>
> The /refresh_all endpoint seems to be broken.
> h1. Steps to reproduce
>  * Login with the Admin role
>  * Make a GET request to the /refresh_all endpoint
> h1. Expected behavior
> The DagBag is refreshed and the client is redirected to /
> h1. Actual behavior
> The server returns an HTTP 500 with the following backtrace:
>  
> {noformat}
> Traceback (most recent call last):
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask/app.py", line 1982, in wsgi_app
>     response = self.full_dispatch_request()
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
>     rv = self.handle_user_exception(e)
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask/app.py", line 1517, in handle_user_exception
>     reraise(exc_type, exc_value, tb)
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask/_compat.py", line 33, in reraise
>     raise value
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
>     rv = self.dispatch_request()
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask/app.py", line 1598, in dispatch_request
>     return self.view_functions[rule.endpoint](**req.view_args)
>   File "~/.virtualenvs/airflow3/lib/python3.7/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
>     return f(self, *args, **kwargs)
>   File "~/src/incubator-airflow/airflow/www/decorators.py", line 56, in wrapper
>     return f(*args, **kwargs)
>   File "~/src/incubator-airflow/airflow/www/views.py", line 1690, in refresh_all
>     for dag_id in dagbag.dags:
> TypeError: sync_perm_for_dag() missing 1 required positional argument: 'dag_id'
> {noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)