[GitHub] [cassandra] Claudenw commented on pull request #1950: WIP: Initial implementation of cassandra-conf with nodetool example - CASSANDRA-17773

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on PR #1950:
URL: https://github.com/apache/cassandra/pull/1950#issuecomment-1445962680

   @michaelsembwever 
   
   1. I agree the name is confusing, does anyone have a better name?  The goal of this change is to simply remove the boilerplate from the other scripts while providing debugging capabilities to more easily detect the issue that caused CASSANDRA-17773.  I did not make any change to operation of the scripts.  Pulling a `cassandra-env.conf` out of `cassandra-env.sh` may be a reasonable thing to do but is outside the scope of this change.
   2. Script is silent by default.  I think you are referring to the `-x` argument.  That was included in error and was a debugging switch.
   3. This script has to run before before we can assume any environment variables are set as it sets many of them through the logic that pulls in the cassandra.in.sh script.  I make 2 assumptions for Cassandra provided scripts.  
       * The scripts in `'bin/` are not to be edited by end users
       * The scripts provided by Cassandra are all deployed in `bin/`.  Thus the `cassandra-conf.sh` will be in the same directory as `nodetool`.  However, I realise that there was an error in the way the file was included.  The code in nodetool now uses `realpath` and `dirname` to figure out where `cassandra-conf.sh` is.  This means that symbolic links to `nodetool` will work correctly.  (other cassandra provided scripts in `bin/` will be configured the same way)
   
   For user created scripts I assume they know where `bin/` is and will modify their scripts to source `cassandra-conf.sh` from there.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org