You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2014/01/31 21:42:08 UTC
[jira] [Updated] (DERBY-6464) Improve the encapsulation of
ResultColumn and ColumnReference
[ https://issues.apache.org/jira/browse/DERBY-6464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-6464:
---------------------------------
Attachment: derby-6464-01-aa-makeFieldsPrivate.diff
Attaching derby-6464-01-aa-makeFieldsPrivate.diff. This patch makes all of the fields of ResultColumn and ColumnReference private and adds accessor methods where necessary. I will run tests.
Touches the following files:
---------------------
M java/engine/org/apache/derby/impl/sql/compile/ColumnReference.java
M java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java
Encapsulation improved for these classes.
---------------------
M java/engine/org/apache/derby/impl/sql/compile/MergeNode.java
M java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java
M java/engine/org/apache/derby/impl/sql/compile/AllResultColumn.java
M java/engine/org/apache/derby/impl/sql/compile/SelectNode.java
M java/engine/org/apache/derby/impl/sql/compile/DeleteNode.java
M java/engine/org/apache/derby/impl/sql/compile/UpdateNode.java
M java/engine/org/apache/derby/impl/sql/compile/FromList.java
M java/engine/org/apache/derby/impl/sql/compile/FromVTI.java
M java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java
M java/engine/org/apache/derby/impl/sql/compile/DMLModStatementNode.java
M java/engine/org/apache/derby/impl/sql/compile/InsertNode.java
M java/engine/org/apache/derby/impl/sql/compile/CurrentOfNode.java
M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
M java/engine/org/apache/derby/impl/sql/compile/CreateViewNode.java
M java/engine/org/apache/derby/impl/sql/compile/PredicateList.java
M java/engine/org/apache/derby/impl/sql/compile/OrderByColumn.java
M java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java
M java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
These classes were adjusted because they were directly reaching into ResultColumn and ColumnReference objects.
> Improve the encapsulation of ResultColumn and ColumnReference
> -------------------------------------------------------------
>
> Key: DERBY-6464
> URL: https://issues.apache.org/jira/browse/DERBY-6464
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.11.0.0
> Reporter: Rick Hillegas
> Attachments: derby-6464-01-aa-makeFieldsPrivate.diff
>
>
> These two classes have a lot of package visible fields. This makes it hard to reason about how they are being used. This issue tracks some improvements to the encapsulation of these classes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)