You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ha...@apache.org on 2026/10/10 07:31:56 UTC
(superset) 01/01: feat(ci): replace `action-validator` with actively maintained `kjanat/actionlint` for GHA workflow static check
This is an automated email from the ASF dual-hosted git repository.
hainenber pushed a commit to branch feat/replace-action-validator-with-a-more-active-maintained-alternative
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 380acf187dccc0079bc4f6cdadfae119415a014b
Author: hainenber <do...@gmail.com>
AuthorDate: Sat Oct 10 14:31:34 2026 +0700
feat(ci): replace `action-validator` with actively maintained `kjanat/actionlint` for GHA workflow static check
Signed-off-by: hainenber <do...@gmail.com>
---
.github/workflows/bump-python-package.yml | 86 ---------------------------
.github/workflows/github-action-validator.sh | 28 ---------
.github/workflows/github-action-validator.yml | 23 +++----
3 files changed, 9 insertions(+), 128 deletions(-)
diff --git a/.github/workflows/bump-python-package.yml b/.github/workflows/bump-python-package.yml
deleted file mode 100644
index 32bceeffdd9..00000000000
--- a/.github/workflows/bump-python-package.yml
+++ /dev/null
@@ -1,86 +0,0 @@
-name: Bump Python Package
-
-on:
- # Can be triggered manually
- workflow_dispatch:
- inputs:
- package:
- required: false
- description: The python package to bump (all if empty)
- group:
- required: false
- description: The optional dependency group to bump (as defined in pyproject.toml)
- limit:
- required: true
- description: Max number of PRs to open (0 for no limit)
- default: 5
- extra-flags:
- required: false
- default: --only-base
- description: Additional flags to pass to the bump-python command
- #schedule:
- # - cron: '0 0 * * *' # Runs daily at midnight UTC
-
-permissions:
- contents: read
-
-jobs:
- bump-python-package:
- runs-on: ubuntu-slim
- permissions:
- actions: write
- contents: write
- pull-requests: write
- checks: write
- steps:
- - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- with:
- persist-credentials: true
- ref: master
-
- - name: Setup supersetbot
- uses: $/.github/actions/setup-supersetbot/
-
- - name: Set up Python ${{ inputs.python-version }}
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
- with:
- python-version: "3.11"
-
- - name: Install uv
- uses: astral-sh/setup-uv@c18668ad3cf93ea998bef934396af7bb5c839dc7 # v10.2.0
- with:
- python-version: "3.11"
- enable-cache: true
-
- - name: supersetbot bump-python -p "${{ github.event.inputs.package }}"
- env:
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- INPUT_PACKAGE: ${{ github.event.inputs.package }}
- INPUT_GROUP: ${{ github.event.inputs.group }}
- INPUT_EXTRA_FLAGS: ${{ github.event.inputs.extra-flags }}
- INPUT_LIMIT: ${{ github.event.inputs.limit }}
- run: |
- git config --global user.email "action@github.com"
- git config --global user.name "GitHub Action"
-
- PACKAGE_OPT=""
- if [ -n "${INPUT_PACKAGE}" ]; then
- PACKAGE_OPT="-p ${INPUT_PACKAGE}"
- fi
-
- GROUP_OPT=""
- if [ -n "${INPUT_GROUP}" ]; then
- GROUP_OPT="-g ${INPUT_GROUP}"
- fi
-
- EXTRA_FLAGS="${INPUT_EXTRA_FLAGS}"
-
- supersetbot bump-python \
- --verbose \
- --use-current-repo \
- --include-subpackages \
- --limit ${INPUT_LIMIT} \
- $PACKAGE_OPT \
- $GROUP_OPT \
- $EXTRA_FLAGS
diff --git a/.github/workflows/github-action-validator.sh b/.github/workflows/github-action-validator.sh
deleted file mode 100755
index 7904a40259c..00000000000
--- a/.github/workflows/github-action-validator.sh
+++ /dev/null
@@ -1,28 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-# Inspired from https://github.com/mpalmer/action-validator?tab=readme-ov-file#pre-commit-hook-example
-echo "Running pre-commit hook for GitHub Actions: https://github.com/mpalmer/action-validator"
- for action in $(git ls-files .github/ | grep -E '^\.github/(workflows|actions)/.*\.ya?ml$'); do
- if action-validator "$action"; then
- echo "✅ $action"
- else
- echo "❌ $action"
- exit 1
- fi
-done
diff --git a/.github/workflows/github-action-validator.yml b/.github/workflows/github-action-validator.yml
index b4988af0114..a8a166bc8b5 100644
--- a/.github/workflows/github-action-validator.yml
+++ b/.github/workflows/github-action-validator.yml
@@ -31,22 +31,17 @@ jobs:
with:
persist-credentials: false
- - name: Set up Node.js
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
- with:
- node-version-file: "./superset-frontend/.nvmrc"
+ - name: Test docs-deploy freshness gate
+ run: bash .github/workflows/scripts/check-docs-deploy-freshness.test.sh
- - name: Install Dependencies
- # Versions are pinned to avoid ad-hoc, unpinned package installs.
- # Bump deliberately when upgrading.
- # zizmor: ignore[adhoc-packages] - @action-validator is a global CLI tool installed to validate the repo's workflows; a global CLI install has no application manifest/lockfile context, and the versions are pinned above
- run: npm install -g @action-validator/core@0.6.0 @action-validator/cli@0.6.0
+ - name: Setup Go
+ uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
- - name: Run Script
- run: bash .github/workflows/github-action-validator.sh
+ - name: Install kjanat/actionlint
+ run: go install actionlint.kjanat.dev/cmd/actionlint@v1.17.0
- - name: Test docs-deploy freshness gate
- run: bash .github/workflows/scripts/check-docs-deploy-freshness.test.sh
+ - name: Static check for GHA workflows
+ run: actionlint
- - name: Check for security issues on GHA workflows
+ - name: Advanced security check for GHA workflows
uses: zizmorcore/zizmor-action@cc914d7f3750a2d13d75c7f184a1060aa0e9d482 # v0.6.4