You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/01/11 01:01:18 UTC

[spark] branch branch-2.4 updated: [SPARK-30489][BUILD] Make build delete pyspark.zip file properly

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 3b029d9  [SPARK-30489][BUILD] Make build delete pyspark.zip file properly
3b029d9 is described below

commit 3b029d911d56f3071e348a7a2c6e1b285143e9fc
Author: Jeff Evans <je...@gmail.com>
AuthorDate: Fri Jan 10 16:59:51 2020 -0800

    [SPARK-30489][BUILD] Make build delete pyspark.zip file properly
    
    ### What changes were proposed in this pull request?
    
    A small fix to the Maven build file under the `assembly` module by switch "dir" attribute to "file".
    
    ### Why are the changes needed?
    
    To make the `<delete>` task properly delete an existing zip file.
    
    ### Does this PR introduce any user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Ran a build with the change and confirmed that a corrupted zip file was replaced with the correct one.
    
    Closes #27171 from jeff303/SPARK-30489.
    
    Authored-by: Jeff Evans <je...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit 582509b7ae76bc298c31a68bcfd7011c1b9e23a7)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 assembly/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/assembly/pom.xml b/assembly/pom.xml
index 432a388..a7d0f0e 100644
--- a/assembly/pom.xml
+++ b/assembly/pom.xml
@@ -117,7 +117,7 @@
           </executions>
           <configuration>
             <target>
-              <delete dir="${basedir}/../python/lib/pyspark.zip"/>
+              <delete file="${basedir}/../python/lib/pyspark.zip"/>
               <zip destfile="${basedir}/../python/lib/pyspark.zip">
                 <fileset dir="${basedir}/../python/" includes="pyspark/**/*"/>
               </zip>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org