You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Prashant Satam <pr...@gmail.com> on 2024/01/12 12:23:43 UTC
Review Request 74836: RANGER-4651 : Need to update Gds objects ACL if ranger principal is deleted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74836/
-----------------------------------------------------------
Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale.
Bugs: RANGER-4651
https://issues.apache.org/jira/browse/RANGER-4651
Repository: ranger
Description
-------
Currently if any principal i.e user/group/role stored in ranger is deleted the GdsObject ACLs still have this principals they dont get removed from the ACL we need to remove this principals from gdsObject ACLs
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java a69647948
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java abf2b0c8c
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java d961bc50c
security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareDao.java 8acca8f89
security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java 5743ad702
security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java 76bab8611
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 52ecf8a3e
Diff: https://reviews.apache.org/r/74836/diff/1/
Testing
-------
Steps to check
1)create a user/group/role in ranger
2)create a dataset and add the above created user/group/role in dataset ACL
3)Delete the user/group/role from ranger
4)The user/group/role will also be removed from ACL of the dataset as well
Thanks,
Prashant Satam
Re: Review Request 74836: RANGER-4651 : Need to update Gds objects ACL if ranger principal is deleted
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74836/
-----------------------------------------------------------
(Updated Jan. 17, 2024, 5:11 a.m.)
Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale.
Bugs: RANGER-4651
https://issues.apache.org/jira/browse/RANGER-4651
Repository: ranger
Description
-------
Currently if any principal i.e user/group/role stored in ranger is deleted the GdsObject ACLs still have this principals they dont get removed from the ACL we need to remove this principals from gdsObject ACLs
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java a69647948
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java abf2b0c8c
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java d961bc50c
security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareDao.java 8acca8f89
security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java 5743ad702
security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java 76bab8611
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 52ecf8a3e
Diff: https://reviews.apache.org/r/74836/diff/2/
Changes: https://reviews.apache.org/r/74836/diff/1-2/
Testing
-------
Steps to check
1)create a user/group/role in ranger
2)create a dataset and add the above created user/group/role in dataset ACL
3)Delete the user/group/role from ranger
4)The user/group/role will also be removed from ACL of the dataset as well
Thanks,
Prashant Satam
Re: Review Request 74836: RANGER-4651 : Need to update Gds objects ACL if ranger principal is deleted
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74836/#review226133
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 12, 2024, 12:23 p.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74836/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2024, 12:23 p.m.)
>
>
> Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale.
>
>
> Bugs: RANGER-4651
> https://issues.apache.org/jira/browse/RANGER-4651
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently if any principal i.e user/group/role stored in ranger is deleted the GdsObject ACLs still have this principals they dont get removed from the ACL we need to remove this principals from gdsObject ACLs
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java a69647948
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java abf2b0c8c
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java d961bc50c
> security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareDao.java 8acca8f89
> security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java 5743ad702
> security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java 76bab8611
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 52ecf8a3e
>
>
> Diff: https://reviews.apache.org/r/74836/diff/1/
>
>
> Testing
> -------
>
> Steps to check
> 1)create a user/group/role in ranger
> 2)create a dataset and add the above created user/group/role in dataset ACL
> 3)Delete the user/group/role from ranger
> 4)The user/group/role will also be removed from ACL of the dataset as well
>
>
> Thanks,
>
> Prashant Satam
>
>