You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jatin510 (via GitHub)" <gi...@apache.org> on 2025/01/22 17:16:25 UTC
Re: [PR] support for `array_repeat` array function [datafusion-comet]
jatin510 commented on code in PR #1205:
URL: https://github.com/apache/datafusion-comet/pull/1205#discussion_r1925689260
##########
native/core/src/execution/planner.rs:
##########
@@ -775,6 +776,49 @@ impl PhysicalPlanner {
Ok(Arc::new(case_expr))
}
+ ExprStruct::ArrayRepeat(expr) => {
+ let src_expr =
+ self.create_expr(expr.left.as_ref().unwrap(), Arc::clone(&input_schema))?;
+ let count_expr =
+ self.create_expr(expr.right.as_ref().unwrap(), Arc::clone(&input_schema))?;
+ // Cast count_expr from Int32 to Int64 to support df count argument
Review Comment:
https://github.com/apache/datafusion/pull/14236
Currently we are manually casting the count_expr to Int64 datatype.
We can remove this once this PR is merged.
##########
native/core/src/execution/planner.rs:
##########
@@ -775,6 +776,49 @@ impl PhysicalPlanner {
Ok(Arc::new(case_expr))
}
+ ExprStruct::ArrayRepeat(expr) => {
+ let src_expr =
+ self.create_expr(expr.left.as_ref().unwrap(), Arc::clone(&input_schema))?;
+ let count_expr =
+ self.create_expr(expr.right.as_ref().unwrap(), Arc::clone(&input_schema))?;
+ // Cast count_expr from Int32 to Int64 to support df count argument
Review Comment:
https://github.com/apache/datafusion/pull/14236
Currently we are manually casting the count_expr to Int64 datatype.
We can remove this once this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org