[jira] [Commented] (PROTON-1060) [Python Binding] API call types for some message properties do not match AMQP specification

["Kim van der Riet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024783#comment-15024783 ] 

Kim van der Riet commented on PROTON-1060:
------------------------------------------

A proposed patch is at https://reviews.apache.org/r/40648/

> [Python Binding] API call types for some message properties do not match AMQP specification
> -------------------------------------------------------------------------------------------
>
>                 Key: PROTON-1060
>                 URL: https://issues.apache.org/jira/browse/PROTON-1060
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>            Reporter: Kim van der Riet
>            Assignee: Kim van der Riet
>
> Several of the Python binding API calls for message properties do not use the correct types.  To align them properly with the AMQP 1.0 spec, the following APIs need changing:
> *Subject*
> The spec for this is: {{<field name="subject" type="string"/>}}
> {{_get_subject()}} should return a unicode string, not a regular string;
> {{_set_subject()}} should accept a unicode string, not a regular string.
> *Content Type*
> The spec for this is: {{<field name="content-type" type="symbol"/>}}
> {{_get_content_type()}} should return a symbol, not a regular string;
> {{_set_content_type()}} should accept a symbol, not a regular string.
> *Content Encoding*
> The spec for this is: {{<field name="content-encoding" type="symbol"/>}}
> {{_get_content_encoding()}} should return a symbol, not a regular string;
> {{_set_content_encoding()}} should accept a symbol, not a regular string.
> *Group Id*
> The spec for this is: {{<field name="group-id" type="string"/>}}
> {{_get_group_id()}} should return a unicode string, not a regular string;
> {{_set_group_id()}} should accept a unicode string, not a regular string.
> *Reply-To Group Id*
> The spec for this is  {{<field name="reply-to-group-id" type="string"/>}}
> {{_get_reply_to_group_id()}} should return a unicode string, not a regular string;
> {{_set_reply_to_group_id()}} should accept a unicode string, not a regular string.
> The unicode string pattern is already established for other message property API calls such as {{_get/_set_address()}} and {{_get/_set_reply_to()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)